[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records
Eli Friedman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 23 10:55:39 PDT 2022
efriedma accepted this revision.
efriedma added a comment.
LGTM with one minor comment (feel free to ignore if you disagree)
Comment at: llvm/lib/Target/ARM/Thumb1FrameLowering.cpp:958
+static void popRegsFromStack(MachineBasicBlock &MBB,
+ MachineBasicBlock::iterator MI,
+ const TargetInstrInfo &TII,
Maybe consider making this an `MachineBasicBlock::iterator&`, so MI isn't a dangling pointer? Not that the result is really any different from what you're doing here, but maybe less confusing.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits