[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

Richard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 23 10:44:14 PDT 2022

LegalizeAdulthood added a comment.

In D128157#3605504 <https://reviews.llvm.org/D128157#3605504>, @jspam wrote:

> @LegalizeAdulthood Not sure what exactly you mean by "fold your changes into `checkers/cppcoreguidelines/virtual-class-destructor.cpp`". The only rebase conflict was in `VirtualClassDestructorCheck.cpp`. Please let me know if there is still something to do.

Clang-Tidy tests and docs have moved to module subdirectories.  You had originally edited the file `checkers/cppcoreguidelines-virtual-class-destructor.cpp` (no subdirectory, file named with module prefix) and this file was moved to `checkers/cppcoreguidelines/virtual-class-destructor.cpp` (now in a module subdirectory, no module prefix in file name).

Looks like git handled it automatically and you didn't notice `:)`.  This is good because it means I did the "right git thing" when I moved/renamed the files and that for most people, simply rebasing should be enough to ensure that their changes are following the file to the new location.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list