[PATCH] D128337: [clang-tidy] Extend spelling for CheckOptions
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 23 09:05:16 PDT 2022
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
In D128337#3602784 <https://reviews.llvm.org/D128337#3602784>, @njames93 wrote:
> In D128337#3602694 <https://reviews.llvm.org/D128337#3602694>, @aaron.ballman wrote:
>> I like the changes -- this is a much nicer syntax for specifying configuration options!
>>> The only observable differences are support for the new syntax and -dump=config will emit using the new syntax.
>> Do you expect the behavior of `-dump` to cause any problems for folks using that option from a script? I can't think of any that aren't super contrived, but maybe you've got more thoughts there.
> I wouldn't expect people are using the dump-config option for any scripts, It's only really there for debugging.
Okay, that works for me!
>> (Note, you should probably rebase your patch as it doesn't seem to apply cleaning, so there's no precommit CI happening for it.)
> That's your fault :) https://github.com/llvm/llvm-project/commit/bb297024fad2f6c3ccaaa6a5c3a270f73f15f3ac
Heh, sorry about that. :-)
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits