[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:928
+    std::tie(Module, Check) = Name.split('-');
+    assert(!Module.empty() && !Check.empty());
+    return {("https://clang.llvm.org/extra/clang-tidy/checks/" + Module + "/" +
----------------
I don't think we should assert on this, how clang-tidy checks are named isn't something clangd can reasonably control.

Instead I'd suggest only returning a value if the condition is met.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128379/new/

https://reviews.llvm.org/D128379