[PATCH] D128357: [clang][dataflow] Store flow condition constraints in a single `FlowConditionConstraints` map.

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun accepted this revision.
xazax.hun added a comment.

I found a small nit inline, otherwise looks good.



================
Comment at: clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp:76
+  if (!Res.second) {
+    FlowConditionConstraints[&Token] =
+        &getOrCreateConjunctionValue(*Res.first->second, Constraint);
----------------
Do you actually need a second lookup? Couldn't you use `Res.first` to update the corresponding value?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128357/new/

https://reviews.llvm.org/D128357