[PATCH] D128337: [clang-tidy] Extend spelling for CheckOptions

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 22 12:28:14 PDT 2022

aaron.ballman added a comment.

I like the changes -- this is a much nicer syntax for specifying configuration options!

> The only observable differences are support for the new syntax and -dump=config will emit using the new syntax.

Do you expect the behavior of `-dump` to cause any problems for folks using that option from a script? I can't think of any that aren't super contrived, but maybe you've got more thoughts there.

(Note, you should probably rebase your patch as it doesn't seem to apply cleaning, so there's no precommit CI happening for it.)

Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:85
+template <>
+void yamlize(IO &io, ClangTidyOptions::OptionMap &Options, bool,
+             EmptyContext &Ctx) {
I'm not super tickled with `IO Io` so if you want to use a more descriptive name, feel free. Mostly just changing it for coding style conformance.

Comment at: clang-tools-extra/docs/ReleaseNotes.rst:113
+- .clang-tidy files can now use the more natural dictionary syntax for specifying `CheckOptions`

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list