[PATCH] D128022: [HIP] add -fhip-kernel-arg-name

[Artem Belevich via Phabricator via cfe-commits]

tra added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1845-1846
+  }
+  if (getCodeGenOpts().EmitOpenCLArgMetadata ||
+      getCodeGenOpts().HIPSaveKernelArgName)
     Fn->setMetadata("kernel_arg_name",
----------------
Should we consolidate both options into `-fkernel-arg-info` and make `-cl-kernel-arg-info` an alias to it?


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1845-1846
+  }
+  if (getCodeGenOpts().EmitOpenCLArgMetadata ||
+      getCodeGenOpts().HIPSaveKernelArgName)
     Fn->setMetadata("kernel_arg_name",
----------------
tra wrote:
> Should we consolidate both options into `-fkernel-arg-info` and make `-cl-kernel-arg-info` an alias to it?
Also, this check is odd. For some reason only *arg name*  metadata is set conditionally, but for whatever reason OpenCL sets other arg metadata unconditionally.

Now I'm really curious what's so special about "kernel_arg_name" vs the other arg metadata.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128022/new/

https://reviews.llvm.org/D128022