[PATCH] D128352: [clang][dataflow] Use diagnosis API in optional checker
Stanislav Gatev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 22 09:10:52 PDT 2022
sgatev added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:58
BlockToOutputState =
- dataflow::runDataflowAnalysis(*Context, Analysis, Env);
+ dataflow::runTypeErasedDataflowAnalysis(*Context, Analysis, Env);
if (!BlockToOutputState)
----------------
I think the typed API should still be preferred unless we make a call to drop it. The type-erased API is only used internally in the dataflow analysis framework. I suggest taking a `DataflowAnalysisState<Lattice>` in `diagnoseCFG` instead of `TypeErasedDataflowAnalysisState` for now. Would that work?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128352/new/
https://reviews.llvm.org/D128352
More information about the cfe-commits
mailing list