[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

Peixin Qiao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 22 09:01:54 PDT 2022


peixin added a comment.

LGTM



================
Comment at: clang/lib/Driver/ToolChains/Flang.cpp:133
+      CmdArgs.push_back("-O3");
+      TC.getDriver().Diag(diag::warn_O4_is_O3);
+    } else {
----------------
Nit: I have committed D126164, and you can rebase and use D directly, which is the style in `Clang.cpp`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128043/new/

https://reviews.llvm.org/D128043



More information about the cfe-commits mailing list