[PATCH] D128204: [clangd] Add fix-it for inserting IWYU pragma: keep

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 21 13:31:06 PDT 2022

njames93 added a comment.

I had another idea about offering the export pragma when in a header file but I don't know if that's going too far

In D128204#3599286 <https://reviews.llvm.org/D128204#3599286>, @kadircet wrote:

> Hence i'd like to hear a little bit more about what kind of false positives you're facing often enough to need this as an automated fix at this stage, to see if there's something we can do to improve the implementation first.

One of the main issues I have is due to templates not being instantiated which can result in symbols that are actually used not being picked up as the template instantiation that uses them isn't actually instantiated.
Unfortunately this isn't something that can be easily fixed without tanking performance.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list