[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null
Philip Reames via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 21 07:35:02 PDT 2022
reames added a comment.
In D126461#3597862 <https://reviews.llvm.org/D126461#3597862>, @craig.topper wrote:
> `dst` in the patch description is not the pointer being loaded, it's the pointer of where to store the new_vl. That is only thing being checked for null in this patch.
I agree this is a possible interpretation, but it's also inconsistent with some of the other review discussion above.
@pcwang-thead Please consider clarifying the patch description a blocking item for future review or potential approval.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits