[PATCH] D127270: [clang-format] Add space in placement new expression

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 21 02:02:18 PDT 2022

MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.

Thanks for the Screenshot, please remember to mark your comments as "Done" once you've addressed them. From what I can tell this looks good.

Comment at: clang/include/clang/Format/Format.h:3559
           AfterFunctionDefinitionName(false), AfterIfMacros(false),
-          AfterOverloadedOperator(false), AfterRequiresInClause(false),
-          AfterRequiresInExpression(false), BeforeNonEmptyParentheses(false) {}
+          AfterOverloadedOperator(false), AfterPlacementOperator(APO_Always),
+          AfterRequiresInClause(false), AfterRequiresInExpression(false),
HazardyKnusperkeks wrote:
> As said in the other comment, there is code that depends on setting to never in the default constructor, so please do.
Why Never and not Leave? basically introducing one or the other as a default won't that causes changes for people who don't want to use this?

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list