[PATCH] D128235: [RISCV] Add support for the Zawrs extension

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 20 20:42:07 PDT 2022


MaskRay added a comment.

> Context not available.

See `-U999999` on https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface or use `arc diff` (PHP 8 may need https://discourse.llvm.org/t/arcanist-deprecation-errors-on-php-8/63231)



================
Comment at: llvm/test/MC/RISCV/zawrs-valid.s:2
+# RUN: llvm-mc %s -triple=riscv32 -mattr=+zawrs \
+# RUN:     | FileCheck -check-prefixes=CHECK-S-OBJ %s
+# RUN: llvm-mc %s -triple=riscv64 -mattr=+zawrs \
----------------
The convention is to use `--check-prefix` is there is only one prefix.


================
Comment at: llvm/test/MC/RISCV/zawrs-valid.s:12
+
+# CHECK-S-OBJ: wrs
+wrs
----------------
Append `{{$}}` to make the test stricter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128235/new/

https://reviews.llvm.org/D128235



More information about the cfe-commits mailing list