[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

Sat Jun 18 23:43:55 PDT 2022

benshi001 added inline comments.

================
Comment at: clang/test/Driver/avr-toolchain.c:83
+// RUN: %clang %s -### --target=avr -mmcu=atmega328 --sysroot=%S/Inputs/basic_avr_tree/ -resource-dir=%S/Inputs/resource_dir_with_per_target_subdir -fuse-ld=%S/Inputs/basic_avr_tree/usr/bin/ld.lld --rtlib=compiler-rt 2>&1 | FileCheck --check-prefix=COMRT %s
+// COMRT: avr/libclang_rt.builtins-avr.a
+// COMRT-NOT: "-lgcc"
----------------
MaskRay wrote:
> `libclang_rt.builtins-avr.a` is the non-longer-recommended LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=off path. Use the LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on path.
> 
> -fuse-ld=abs/path is deprecated. Use --ld-path or carefully use -fuse-ld=lld to select lld.
Thanks. I will fix that in another review request https://reviews.llvm.org/D128133.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127186/new/

https://reviews.llvm.org/D127186