[PATCH] D127207: [flang][driver] Fix support for `-x`

[Andrzej Warzynski via Phabricator via cfe-commits]

awarzynski added a comment.

In D127207#3593665 <https://reviews.llvm.org/D127207#3593665>, @sunho wrote:

> Hi! I'm not exactly sure what's going on. But, seems like build is failing here? https://lab.llvm.org/buildbot/#/builders/177/builds/5571

Thanks for flagging this up! I am also rather confused. I checked the list of changes for that buildbot job  and it all looks totally unrelated to `flang-new -x`. The error is:

  ******************** TEST 'Flang :: Driver/input-from-stdin-llvm.ll' FAILED ********************
  Script:
  --
  : 'RUN: at line 10';   cat /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/flang/test/Driver/input-from-stdin-llvm.ll | /home/tcwg-buildbot/worker/flang-aarch64-dylib/build/bin/not /home/tcwg-buildbot/worker/flang-aarch64-dylib/build/bin/flang-new -S - -o -
  : 'RUN: at line 11';   cat /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/flang/test/Driver/input-from-stdin-llvm.ll | /home/tcwg-buildbot/worker/flang-aarch64-dylib/build/bin/not /home/tcwg-buildbot/worker/flang-aarch64-dylib/build/bin/flang-new -fc1 -S - -o -
  : 'RUN: at line 14';   cat /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/flang/test/Driver/input-from-stdin-llvm.ll | /home/tcwg-buildbot/worker/flang-aarch64-dylib/build/bin/flang-new -x ir -S -target aarch64-unknown-linux-gnu - -o - | /home/tcwg-buildbot/worker/flang-aarch64-dylib/build/bin/FileCheck /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/flang/test/Driver/input-from-stdin-llvm.ll
  : 'RUN: at line 15';   cat /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/flang/test/Driver/input-from-stdin-llvm.ll | /home/tcwg-buildbot/worker/flang-aarch64-dylib/build/bin/flang-new -fc1 -x ir -S -triple aarch64-unknown-linux-gnu - -o - | /home/tcwg-buildbot/worker/flang-aarch64-dylib/build/bin/FileCheck /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/flang/test/Driver/input-from-stdin-llvm.ll
  --
  Exit Code: 141
  Command Output (stderr):
  --
  + : 'RUN: at line 10'
  + /home/tcwg-buildbot/worker/flang-aarch64-dylib/build/bin/not /home/tcwg-buildbot/worker/flang-aarch64-dylib/build/bin/flang-new -S - -o -
  + cat /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/flang/test/Driver/input-from-stdin-llvm.ll
  error: Could not scan -
  standard input:10:15: error: bad character ('|') in Fortran token
    ; RUN: cat %s | not %flang -S - -o -
                  ^
  standard input:11:15: error: bad character ('|') in Fortran token
    ; RUN: cat %s | not %flang_fc1 -S - -o -
                  ^
  standard input:14:15: error: bad character ('|') in Fortran token
    ; RUN: cat %s | %flang -x ir -S -target aarch64-unknown-linux-gnu - -o - | FileCheck %s
                  ^
  standard input:14:74: error: bad character ('|') in Fortran token
    ; RUN: cat %s | %flang -x ir -S -target aarch64-unknown-linux-gnu - -o - | FileCheck %s
                                                                             ^
  standard input:15:15: error: bad character ('|') in Fortran token
    ; RUN: cat %s | %flang_fc1 -x ir -S -triple aarch64-unknown-linux-gnu - -o - | FileCheck %s
                  ^
  standard input:15:78: error: bad character ('|') in Fortran token
    ; RUN: cat %s | %flang_fc1 -x ir -S -triple aarch64-unknown-linux-gnu - -o - | FileCheck %s
                                                                                 ^
  standard input:26:20: error: bad character ('{') in Fortran token
    define void @foo() {
                       ^
  standard input:28:1: error: bad character ('}') in Fortran token
    }
    ^
  + : 'RUN: at line 11'
  + /home/tcwg-buildbot/worker/flang-aarch64-dylib/build/bin/not /home/tcwg-buildbot/worker/flang-aarch64-dylib/build/bin/flang-new -fc1 -S - -o -
  + cat /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/flang/test/Driver/input-from-stdin-llvm.ll
  error: Invalid input type - expecting a Fortran file
  --
  ********************

But lines 10 and 11 in input-from-stdin-llvm.ll <https://github.com/llvm/llvm-project/blob/main/flang/test/Driver/input-from-stdin-llvm.ll#L10-L11> //are expected to fail// and hence there's `not %flang` rather than `%flang` 🤔 . The subsequent buildbot job <https://lab.llvm.org/buildbot/#/builders/177/builds/5572> is fine, so probably no need to change anything just now. But I will monitor this!

Thanks again for letting me know!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127207/new/

https://reviews.llvm.org/D127207