[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 17 16:16:49 PDT 2022


MaskRay added inline comments.


================
Comment at: clang/test/Driver/compilation_database_multiarch.c:15
 // CHECK-NEXT: { "directory": "{{.*}}", "file": "{{.*}}", "output": "[[OUTPUT_ARM64:.*]]", "arguments": [{{.*}}, "-o", "[[OUTPUT_ARM64]]", {{.*}} "--target=arm64-apple-macosx12.0.0"]},
+// CHECK-NEXT: EOF
----------------
jansvoboda11 wrote:
> MaskRay wrote:
> > CHECK-EMPTY can match EOF.
> It can, but it's not really strict. It will match an empty line, but that might be followed by some non-empty lines, which I'd like this test to explicitly disallow.
OK. I think `CHECk-NOT: {{.}}` works as well once the last byte before \n is matched.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128098/new/

https://reviews.llvm.org/D128098



More information about the cfe-commits mailing list