[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

Fri Jun 17 07:17:38 PDT 2022

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM! The debian failures look like precommit CI is in a broken state again, but have nothing to do with your patch.

================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8849
     break;
-  
   // HLSL attributes:
----------------
hctim wrote:
> aaron.ballman wrote:
> > hctim wrote:
> > > aaron.ballman wrote:
> > > > Spurious whitespace change?
> > > unfortunately there's no way in my editor to trim trailing whitespace only on changed lines :(, so i end up fixing things like this drive-by.
> > > 
> > > let me know if you feel very strongly about this diff and I can kill it, but I personally think the drive-by-fix isn't a huge problem and the alternative of whitespace-fix-only commit seems a bit overkill
> > Personally, I don't feel very strongly because the chances of the whitespace being someone's entrypoint to git-blame is pretty minimal (especially given there's only one change here). However, we typically still ask for formatting changes to be separated out (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access #2) rather than lumped in with functional changes so reviewers will ask for these sort of changes to be backed out, so this may crop up repeatedly if your editor doesn't give you the options you need.
> Fixed in ee28837a1fbd574dbec14b9f09cb4effab6a492a.
Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127544/new/

https://reviews.llvm.org/D127544