[PATCH] D128049: [mlir] move SCF headers to SCF/{IR,Transforms} respectively

[Alex Zinenko via Phabricator via cfe-commits]

ftynse marked an inline comment as done.
ftynse added inline comments.


================
Comment at: mlir/include/mlir/Dialect/SCF/Transforms/Transforms.h:13
 
-#ifndef MLIR_DIALECT_SCF_TRANSFORMS_H_
-#define MLIR_DIALECT_SCF_TRANSFORMS_H_
+#ifndef MLIR_DIALECT_SCF_TRANSFORMS_TRANSFORMS_H_
+#define MLIR_DIALECT_SCF_TRANSFORMS_TRANSFORMS_H_
----------------
jpienaar wrote:
> Transforms transforms feels a bit strange, for many others I believe this would have been passes file (which is also not that accurate, patterns and passes would be more, but most others it is just passes and convenient shorthand). Keeping the move mostly mechanical is good though 
There's already Transforms/Passes.h and Transforms/Patterns.h, these things are more like standalone transform functions. Maybe Transforms/Utils.h?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128049/new/

https://reviews.llvm.org/D128049