[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 17 06:24:08 PDT 2022


beanz added a comment.

For just the type alias, adding it during parsing would probably work. Where things get more complicated is we have a whole mess of other data types that we’ll need to add too eventually. One of the advantages of using an external sema source is that we can create incomplete records during initialization, and complete them when the sema source gets the callback from lookup. That gives us cheap and efficient lazy-initialization of our buffer types which (in DXC) has a huge impact on compile time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128012/new/

https://reviews.llvm.org/D128012



More information about the cfe-commits mailing list