[PATCH] D128036: [CMake] Option to select C++ library for runtimes that use it

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added inline comments.


================
Comment at: compiler-rt/CMakeLists.txt:534
+if (COMPILER_RT_CXX_LIBRARY STREQUAL "libcxx")
+  # We are using the in-tree libc++ so avoid including the default one.
+  append_list_if(COMPILER_RT_HAS_NOSTDINCXX_FLAG -nostdinc++ COMPILER_RT_COMMON_CFLAGS)
----------------
Does this mean that if you set `COMPILER_RT_CXX_LIBRARY=libcxx`, it's assumed that you're actually _building_ that same libcxx in the same cmake invocation?

I'm currently building compiler-rt in a standalone cmake invocation, separate from all the others, with `-DSANITIZER_CXX_ABI=libc++`. Building them all at once might be something I could consider at some point, but I wouldn't want to force that situation right now, if it could be avoided?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128036/new/

https://reviews.llvm.org/D128036