[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

[Mingming Liu via Phabricator via cfe-commits]

mingmingl marked an inline comment as done.
mingmingl added inline comments.


================
Comment at: clang/test/Preprocessor/aarch64-target-features.c:22
 // CHECK-NOT: __ARM_FEATURE_CRC32 1
+// CHECK-NOT: __ARM_FEATURE_RCPC 1
 // CHECK-NOT: __ARM_FEATURE_CRYPTO 1
----------------
MaskRay wrote:
> The list is alphabetical. RCPC should be moved below.
good catch. done.


================
Comment at: clang/test/Preprocessor/aarch64-target-features.c:566
+
+// RUN: %clang -target aarch64-none-linux-gnu -march=armv8.2-a+rcpc -x c -E -dM %s -o - | FileCheck --check-prefix=CHECK-RCPC %s
+// CHECK-RCPC: __ARM_FEATURE_RCPC 1
----------------
MaskRay wrote:
> `--target=aarch64`
done. thanks for pointing this out!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127798/new/

https://reviews.llvm.org/D127798