[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

I probably need to spend more time on this at one point, but first look seemed fine to me.  I think the approach is about right, and the solution is there.

@aaron.ballman  is messing with the constexpr-ness of SM functions, so there is likely some collaboration that needs to be doen to make sure we get THIS right as well.



================
Comment at: clang/docs/ReleaseNotes.rst:434
 
+- As per "Conditionally Trivial Special Member Functions" (P0848), it is
+  now possible to overload destructors using concepts. Note that the rest
----------------
Do we have enough to update cxx_status.html?


================
Comment at: clang/include/clang/AST/DeclBase.h:1603
+    /// [class.mem.special].
+    uint64_t IsIneligibleOrNotSelected : 1;
+
----------------
Hrumph... its a shame to lose the bit here later.  I wonder if at one point in a future patch we should figure out which of these flags can be moved to an 'allocated in Trailing-storage ONLY if required' type deal, like we just did with FunctionTypeBitFields...


================
Comment at: clang/include/clang/AST/DeclCXX.h:1430
+  /// out of which one will be selected at the end.
+  /// This is called separately from addedMember because it has to be deferred
+  /// to the completion of the class.
----------------
@aaron.ballman  is messing around with addedMember recently... I wonder if there are OTHER decisions that need to be updated/moved here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126194/new/

https://reviews.llvm.org/D126194