[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

[Balázs Benics via Phabricator via cfe-commits]

steakhal added a comment.

Awesome!

The generated doc section looks great. The test coverage it excellent, but I would recommend adding tests for covering the following lines:

- `ErrnoChecker.cpp:99`
- `ErrnoModeling.cpp:259`
- `ErrnoModeling.cpp:264`

There are two other uncovered cases, but those are mainly defensive checks, so I don't mind them.



================
Comment at: clang/docs/analyzer/checkers.rst:2565
+value is not used in a condition. For example ``errno`` can be stored into a
+variable without getting a warning from the checker.
+
----------------
by


================
Comment at: clang/docs/analyzer/checkers.rst:2586
+   or returned from a function.
+ - Documentation of function `lseek` is not clear about what happens if the
+   function returns different value than the expected file position but not -1.
----------------
I think it should be surrounded by double backticks. It looks ugly this way:
{F23478405}


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122150/new/

https://reviews.llvm.org/D122150