[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added a comment.

provide full context of the changes.



================
Comment at: clang/include/clang/AST/OpenMPClause.h:7646
 
-  /// A kind of the 'default' clause.
+  /// A kind of the 'order' clause.
   OpenMPOrderClauseKind Kind = OMPC_ORDER_unknown;
----------------
Commit as NFC change


================
Comment at: clang/include/clang/Sema/Scope.h:483-488
+  /// Determine whether this scope is some OpenMP directive with
+  /// order clause which specifies concurrent scope.
+  bool isOpenMPOrderClauseScope() const{
+    return getFlags() & Scope::OpenMPOrderClauseScope;
+  }
+
----------------
Why do wee need new scope?


================
Comment at: clang/lib/Basic/OpenMPKinds.cpp:649-654
+  return DKind == OMPD_parallel_do || DKind == OMPD_parallel_do_simd ||
+         DKind == OMPD_parallel_for || DKind == OMPD_parallel_for_simd ||
+         DKind == OMPD_parallel_master ||
+         DKind == OMPD_parallel_master_taskloop ||
+         DKind == OMPD_parallel_master_taskloop_simd ||
+         DKind == OMPD_parallel_workshare || DKind == OMPD_parallel_sections;
----------------
C/C++ does not have do and workshare directives.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127855/new/

https://reviews.llvm.org/D127855