[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

Thu Jun 16 05:16:41 PDT 2022

iliya-diyachkov added a comment.

In D127579#3585411 <https://reviews.llvm.org/D127579#3585411>, @Anastasia wrote:

> Also is there anything that we don't need from the metadata that are currently emitted for the use case i.e. for example argument names? This could reduce the number of metadata emitted...

Sure, I think we don't need all info. As I mentioned in TODO I'm going to leave only type info and remove other metadata emission. For this purpose I'll separate a new function (that emits the type info) from GenOpenCLArgMetadata.

In D127579#3586472 <https://reviews.llvm.org/D127579#3586472>, @jcranmer-intel wrote:

> I haven't yet tested whether or not this patch is sufficient to support all of the use cases I need for type scavenging for SPIR-V, but one of the things I do see is that there's no support for return type information, which may be a bit of an issue.

I think the return type information can be added in the next version of the patch, however it should be attached to function declarations (not definitions as it's done now), right? Do you think, declarations also require information about argument types?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127579/new/

https://reviews.llvm.org/D127579