[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

[Stanislav Mekhanoshin via Phabricator via cfe-commits]

rampitec added inline comments.


================
Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-dl-insts-err.cl:1
 // REQUIRES: amdgpu-registered-target
 
----------------
Also need positive tests like in builtins-amdgcn-dl-insts.cl.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1926
 
+// f16 %r = llvm.amdgcn.fdot2.f16.f16(v2f16 %a, v2f16 %b, f16 %c, i1 %clamp)
+//   %r = %a[0] * %b[0] + %a[1] * %b[1] + %c
----------------
I do not see clamp in the definition. Make a separate comment for the last 2?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127904/new/

https://reviews.llvm.org/D127904