[clang] 1082285 - Rolling back tests for WG14 DR145

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 15 12:38:33 PDT 2022


Author: Aaron Ballman
Date: 2022-06-15T15:37:14-04:00
New Revision: 10822857b7d5218a36eb36e36b924f10d981b67c

URL: https://github.com/llvm/llvm-project/commit/10822857b7d5218a36eb36e36b924f10d981b67c
DIFF: https://github.com/llvm/llvm-project/commit/10822857b7d5218a36eb36e36b924f10d981b67c.diff

LOG: Rolling back tests for WG14 DR145

Several build bots are failing with surprising behavior, so it's less
clear whether we do or don't implement this DR properly.

https://lab.llvm.org/buildbot/#/builders/91/builds/10454
https://lab.llvm.org/buildbot/#/builders/109/builds/40668
https://lab.llvm.org/buildbot/#/builders/139/builds/23334

Added: 
    

Modified: 
    clang/test/C/drs/dr1xx.c
    clang/www/c_dr_status.html

Removed: 
    


################################################################################
diff  --git a/clang/test/C/drs/dr1xx.c b/clang/test/C/drs/dr1xx.c
index fed5fdd69101..cbcc0524105f 100644
--- a/clang/test/C/drs/dr1xx.c
+++ b/clang/test/C/drs/dr1xx.c
@@ -319,11 +319,15 @@ void dr142(void) {
 # DR144 include <stddef.h> /* expected-error {{invalid preprocessing directive}} */
 DR144 # include <stddef.h> /* expected-error {{expected identifier or '('}} */
 
-/* WG14 DR145: yes
+/* WG14 DR145:
  * Constant expressions
  */
 void dr145(void) {
   static int array[10];
   static int *ip = (int *)0;
-  static int i = array[0] + array[1]; /* expected-error {{initializer element is not a compile-time constant}} */
+  /* The below is failing because some systems think this is a valid compile-
+   * time constant. Commenting the out while investigating whether we implement
+   * this DR properly or not.
+   * static int i = array[0] + array[1]; broken-expected-error {{initializer element is not a compile-time constant}}
+   */
 }

diff  --git a/clang/www/c_dr_status.html b/clang/www/c_dr_status.html
index 0b16bd55b299..c00fd511ef41 100644
--- a/clang/www/c_dr_status.html
+++ b/clang/www/c_dr_status.html
@@ -925,7 +925,7 @@ <h2 id="cdr">C defect report implementation status</h2>
     <td><a href="https://www.open-std.org/jtc1/sc22/wg14/www/docs/dr_145.html">145</a></td>
     <td>C89</td>
     <td>Constant expressions</td>
-    <td class="full" align="center">Yes</td>
+    <td class="unknown" align="center">Unknown</td>
   </tr>
   <tr id="146">
     <td><a href="https://www.open-std.org/jtc1/sc22/wg14/www/docs/dr_146.html">146</a></td>


        


More information about the cfe-commits mailing list