[PATCH] D127876: [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

Peter Collingbourne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 15 10:21:36 PDT 2022


pcc added a comment.

In D127876#3586154 <https://reviews.llvm.org/D127876#3586154>, @aeubanks wrote:

> In D127876#3586134 <https://reviews.llvm.org/D127876#3586134>, @pcc wrote:
>
>> This diverges from the documented behavior of `-lto-whole-program-visibility`. The flag is meant to give all classes hidden LTO visibility, but now it only does that to some of them.
>
> perhaps I'm misunderstanding, but even with `-lto-whole-program-visibility` classes explicitly marked with public LTO visibility still shouldn't participate in WPD?

We documented the feature in D75655 <https://reviews.llvm.org/D75655> and there it says "all classes" (and still does).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127876/new/

https://reviews.llvm.org/D127876



More information about the cfe-commits mailing list