[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

[Dávid Bolvanský via Phabricator via cfe-commits]

xbolva00 added inline comments.


================
Comment at: clang/docs/ReleaseNotes.rst:304
+  all functions following the pragma. At the moment, only an empty list is
+  supported.
 
----------------
xbolva00 wrote:
> So to sum up.. #pragma optimize("", off) disables all optimizations, right?
> 
> #pragma optimize("", on) enables all, right? is no op if compiled with -O0?
> 
> 
> Other than this release note, looks like there is no way to specifiy own documentation for pragmas? :/ 
> 
> Especially if there are differences between MSVC and current implementation...
Plus, maybe we should emit a warning if #pragma optimize("", on)  is used with -O0?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125723/new/

https://reviews.llvm.org/D125723