[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added a comment.

The patch seems very straight forward. I wonder though if we should always enable this for SPIR-V w/o  adding any flag until the untyped pointers are added to SPIR-V so it will become a target setting controlled instead of a flag?

Also is there anything that we don't need from the metadata that are currently emitted for the use case i.e. for example argument names? This could reduce the number of metadata emitted...

I am not sure if this is something that other languages or backends might also need in which case we might need to make this more universal... Ideally it would be nice if it was not in metadata as it is somewhat optional... but potentially we don't have many other alternatives?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127579/new/

https://reviews.llvm.org/D127579