[PATCH] D127838: [analyzer][NFC] Remove dead field of UnixAPICheckers

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 15 05:44:46 PDT 2022


steakhal added a comment.

In D127838#3584911 <https://reviews.llvm.org/D127838#3584911>, @martong wrote:

> Umm, why this can't be part of D127836 <https://reviews.llvm.org/D127836> ?

It can be, but I wanted to still do this separately. The reasoning in the summary should nominate this to a separate discussion.
Just consider if it was a real catch. I would definitely not wanted it to be part of that generic refactor change.
In the end, it turned out to be not the case, but I wanted to be explicit about this.

That being said, I'd insist.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127838/new/

https://reviews.llvm.org/D127838



More information about the cfe-commits mailing list