[PATCH] D127812: [AArch64] Function multiversioning support added.

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 14 21:34:28 PDT 2022


MaskRay added inline comments.


================
Comment at: clang/docs/ClangCommandLineReference.rst:1086
 
+.. option:: -mno-fmv
+
----------------
This file is auto-generated. Don't touch it.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1173
     return None;
-  case ARM::BI_BitScanForward:
-  case ARM::BI_BitScanForward64:
+  case clang::ARM::BI_BitScanForward:
+  case clang::ARM::BI_BitScanForward64:
----------------
This can be committed separately.


================
Comment at: clang/test/CodeGen/attr-target-version.c:75
+
+//.
+// CHECK: @__aarch64_cpu_features = external dso_local global { i64 }
----------------
Remove `//.` and `// <empty>`.

Note: some editors like neovim supports `{` `}` to navigate among paragraphs. Adding `//` just adds inconvenience.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127812/new/

https://reviews.llvm.org/D127812



More information about the cfe-commits mailing list