[PATCH] D126192: [Driver] Improve linking options for target AVR

Tue Jun 14 19:07:42 PDT 2022

benshi001 added a comment.

In D126192#3583924 <https://reviews.llvm.org/D126192#3583924>, @haowei wrote:

> In D126192#3583915 <https://reviews.llvm.org/D126192#3583915>, @benshi001 wrote:
>
>> It seems the file `/mnt/nvme_sec/SRC/llvm-project/clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld` is missing on your machine, which I have newly created in current patch.
>
> That file was missing. For some reason, it was missing from the patch I downloaded from phabricator( if you look at https://reviews.llvm.org/file/data/2wqpf52swpb3xkcz7lip/PHID-FILE-filks6eto62wxww6m23w/D126192.vson.id436992.diff).
>
> After manually create clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld and set permission to 0755 (test will fail if I don't do it). All tests will pass under linux-x64. I will need to test it on a Windows host to make sure it all pass, which will take a while.

Thanks. I really appreciate your help.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126192/new/

https://reviews.llvm.org/D126192