[PATCH] D127742: [analyzer][NFC] Prefer using isa<> instead getAs<> in conditions

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 14 08:16:58 PDT 2022


martong added a comment.

Why not replace all `getAs`?

I suppose you picked conditions because `isa` can have variadic parameters. If we are about to keep `getAs` then why not replace only those occurrences where we see the benefit of the variadic `isa`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127742/new/

https://reviews.llvm.org/D127742



More information about the cfe-commits mailing list