[PATCH] D126291: [flang][Driver] Update link job on windows

Diana Picus via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 14 01:21:22 PDT 2022


rovka added inline comments.


================
Comment at: flang/test/Driver/linker-flags.f90:51
+! MSVC-NOT: libcmt
+! MSVC-NOT: oldnames
+! MSVC-SAME: "[[object_file]]"
----------------
mmuetzel wrote:
> Lines 50-51 seem to be duplicates of lines 44-45. Is this intentional?
Yes, I don't want those to appear either before or after the Fortran libs. I guess if we wanted to be pedantic we'd also check that they don't appear after the object_file, or between the libs and the subsystem, but that seems a bit much.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126291/new/

https://reviews.llvm.org/D126291



More information about the cfe-commits mailing list