[PATCH] D127486: [analyzer][NFC] Inline AnalyzerOptions::getUserMode()

Mon Jun 13 23:53:14 PDT 2022

martong accepted this revision.
martong added inline comments.
This revision is now accepted and ready to land.

================
Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:362-364
-  /// Retrieves and sets the UserMode. This is a high-level option,
-  /// which is used to set other low-level options. It is not accessible
-  /// outside of AnalyzerOptions.
----------------
steakhal wrote:
> martong wrote:
> > I would miss this comment.
> Which part do you miss?
> 
> The `AnalyzerOptions.def` already has a //half descent// description about this:
> > (string) Controls the high-level analyzer mode, which influences the default settings for some of the lower-level config options (such as IPAMode). Value: "deep", "shallow".
> 
> If you insist, let me know what comment should I put and where.
If AnalyzerOptions.def has it then it was already redundant, so okay then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127486/new/

https://reviews.llvm.org/D127486