[PATCH] D127647: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap()
Ben Barham via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 13 12:39:26 PDT 2022
bnbarham added a comment.
The failure here is likely due to the hack in FileManager::getFileRef:
// FIXME: This hack ensures that `getDir()` will use the path that was
// used to lookup this file, even if we found a file by different path
// first. This is required in order to find a module's structure when its
// headers/module map are mapped in the VFS.
So the directory returned from the FileEntry is the *lookup* directory, but the FileEntryRef will be giving back the directory from the external path (if it has been remapped).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127647/new/
https://reviews.llvm.org/D127647
More information about the cfe-commits
mailing list