[PATCH] D127673: [OpenMP] Fix offload packager not writing to temps correctly

[Joseph Huber via Phabricator via cfe-commits]

jhuber6 marked an inline comment as done.
jhuber6 added a comment.

Thanks for the review.



================
Comment at: clang/lib/Driver/Driver.cpp:5420
+        /*CreatePrefixForHost=*/isa<OffloadPackagerJobAction>(A) ||
+            (!!A->getOffloadingHostActiveKinds() && !AtTopLevel));
     if (isa<OffloadWrapperJobAction>(JA)) {
----------------
tra wrote:
> `!!` assumes specific values for the mask returned by getOffloadingHostActiveKinds().
> 
> `(A->getOffloadingHostActiveKinds() != OFK_None && !AtTopLevel)` would be a bit easier to understand, IMO.
> Maybe even `!(A->getOffloadingHostActiveKinds() == OFK_None || AtTopLevel)`.
> 
That was confusing me as well, might as well change it while I'm here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127673/new/

https://reviews.llvm.org/D127673