[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 13 11:20:27 PDT 2022


rjmccall added a comment.

Minor suggestion for a cleanup, then LGTM.



================
Comment at: clang/lib/Sema/SemaOverload.cpp:9048
+                ParamTypes[0] = S.Context.getVolatileType(ParamTypes[0]);
+              ParamTypes[0] = S.Context.getLValueReferenceType(ParamTypes[0]);
+              S.AddBuiltinCandidate(ParamTypes, Args, CandidateSet);
----------------
Can you add a helper function to build this qualified l-value reference type from a `QualifiersAndAtomic`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125349/new/

https://reviews.llvm.org/D125349



More information about the cfe-commits mailing list