[PATCH] D127660: [clang][lex] NFCI: Use DirectoryEntryRef in Preprocessor::MainFileDir

Ben Barham via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 13 11:02:33 PDT 2022


bnbarham accepted this revision.
bnbarham added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Frontend/FrontendAction.cpp:507
   // be resolved relative to the build directory of the module map file.
-  CI.getPreprocessor().setMainFileDir(M->Directory);
+  CI.getPreprocessor().setMainFileDir(*M->Directory);
 
----------------
Same as in previous review, is this guaranteed to be set? Might be worth a comment on the field itself if so (in https://reviews.llvm.org/D127654)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127660/new/

https://reviews.llvm.org/D127660



More information about the cfe-commits mailing list