[PATCH] D127648: [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::inferFrameworkModule()

[Ben Barham via Phabricator via cfe-commits]

bnbarham accepted this revision.
bnbarham added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Lex/ModuleMap.cpp:1028
   // Look for an umbrella header.
-  SmallString<128> UmbrellaName = StringRef(FrameworkDir->getName());
+  SmallString<128> UmbrellaName = StringRef(FrameworkDir.getName());
   llvm::sys::path::append(UmbrellaName, "Headers", ModuleName + ".h");
----------------
Nit: `getName()` is already a `StringRef` (it was previously too, but I assume that wasn't the case at ... some point).


================
Comment at: clang/lib/Lex/ModuleMap.cpp:1073
   std::error_code EC;
-  SmallString<128> SubframeworksDirName
-    = StringRef(FrameworkDir->getName());
+  SmallString<128> SubframeworksDirName = StringRef(FrameworkDir.getName());
   llvm::sys::path::append(SubframeworksDirName, "Frameworks");
----------------
Same thing here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127648/new/

https://reviews.llvm.org/D127648