[PATCH] D127201: [clang] Add tests for statement expression in initializers

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 13 07:58:22 PDT 2022


erichkeane added a comment.

The command line on one of the tests is a little strange to me, and I don't see the need for the -std=gnu11 on either, but the test content itself looks fine enough to me.



================
Comment at: clang/test/CodeGen/stmtexpr-init.c:1
+// RUN: %clang_cc1 -O -std=gnu11 %s -emit-llvm -o - | FileCheck %s
+
----------------
why the -std=gnu11 here?  I would assume our default would be enough?  Also, why the opt-flag?  That likely is unnecessary/will cause 'bad things' to happen.  Clang tests typically don't use the opt flags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127201/new/

https://reviews.llvm.org/D127201



More information about the cfe-commits mailing list