[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

[Mikael Holmén via Phabricator via cfe-commits]

uabelho added inline comments.


================
Comment at: clang/tools/driver/cc1as_main.cpp:323-329
+  if (auto *A = Args.getLastArg(OPT_femit_dwarf_unwind_EQ)) {
+    Opts.EmitDwarfUnwind =
+        llvm::StringSwitch<EmitDwarfUnwindType>(A->getValue())
+            .Case("always", EmitDwarfUnwindType::Always)
+            .Case("no-compact-unwind", EmitDwarfUnwindType::NoCompactUnwind)
+            .Case("default", EmitDwarfUnwindType::Default);
+  }
----------------
int3 wrote:
> still building ASAN but this looks sus -- if no flag gets passed, we never initialize `EmitDwarfUnwind` before using it on line 381
> 
> also it occurred to me that if the buildbots haven't flagged anything, ASAN probably can't detect this. Let me just put up a patch
We have bots running ASAN on this without complaining.

A patch sounds good! Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122258/new/

https://reviews.llvm.org/D122258