[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

[Balázs Kéri via Phabricator via cfe-commits]

balazske marked an inline comment as done.
balazske added a comment.

Ping
I have a question with Objective-C support.
@njames93 Could you look at this again?



================
Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:126
     const LangOptions &LangOpts) const {
-  // FIXME: Make the checker useful on C++ code.
-  if (LangOpts.CPlusPlus)
+  if (LangOpts.CPlusPlus17)
     return false;
----------------
balazske wrote:
> LegalizeAdulthood wrote:
> > njames93 wrote:
> > > Is this check valid on Objective-C code?
> > `return LangOpts.CPlusPlus17 == 0;`
> I do not know if the check is applicable to Objective-C, it may depend on if the C standard (or POSIX) is applicable to Objective-C.
I could not find out if it is valid for Objective-C, probably not? But there are other checkers (for example in the `concurrency` module) that look POSIX or runtime-library specific and these do not contain check for ObjC language.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118996/new/

https://reviews.llvm.org/D118996