[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 11 12:35:47 PDT 2022


rjmccall added a comment.

The cleanups arise from expressions in the constraints, right?  There are a number of places where `ExprWithCleanups` does not mean the cleanups are independently nested within that expression; it's notably not how it works ever for something as basic as a variable initializer.  If we want the lifetime of temporaries in asm operands to include the full duration of the asm statement, I think we can just declare by fiat that that's how it works for `AsmStmt` instead of unnaturally wrapping things this way.

Or do we have a problem where the semantics are different for different kinds of asm statements?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125936/new/

https://reviews.llvm.org/D125936



More information about the cfe-commits mailing list