[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

[David Goldman via Phabricator via cfe-commits]

dgoldman added inline comments.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:847-849
+            } else if (const auto Iface =
+                           dyn_cast<const ObjCInterfaceDecl>(Decl)) {
+              if (Iface->isThisDeclarationADefinition())
----------------
Do we need similar code for ObjCProtocolDecl? Also should ObjCImplDecl be considered definitions here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127403/new/

https://reviews.llvm.org/D127403