[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

[Shivam Gupta via Phabricator via cfe-commits]

xgupta added inline comments.


================
Comment at: clang/www/get_started.html:72
     <li><tt>cd build</tt></li>
+    <li>This builds both LLVM and Clang for debug mode and takes a lot of time and space. Alternatively -DCMAKE_BUILD_TYPE=Release" can be use to make a release build.</li>
     <li><tt>cmake -DLLVM_ENABLE_PROJECTS=clang -G "Unix Makefiles" ../llvm</tt></li>
----------------
aaron.ballman wrote:
> thieta wrote:
> > This isn't correct - invoking cmake without a `CMAKE_BUILD_TYPE` argument will just print an error. I would fix the command line below to include `-DCMAKE_BUILD_TYPE=Release` and have a comment saying switch Release to Debug if you need a debug build.
> +1 to most of this, but I'd have the comment say something along the lines of "See https://llvm.org/docs/CMake.html#frequently-used-cmake-variables for more options".
I hope 'most of this' also includes making changes to the default suggestion of  -DCMAKE_BUILD_TYPE :) 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127496/new/

https://reviews.llvm.org/D127496