[PATCH] D126291: [flang][Driver] Update link job on windows

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added a comment.

In D126291#3573742 <https://reviews.llvm.org/D126291#3573742>, @mmuetzel wrote:

> In D126291#3573607 <https://reviews.llvm.org/D126291#3573607>, @mstorsjo wrote:
>
>> FWIW, something very similar was added just a couple days ago in an lldb specific lit.cfg.py: https://reviews.llvm.org/D127048#change-KJ7QgKPHtN1S
>
> Thank you for pointing this out.
> Those feature definitions for the lldb subproject probably stem from around here:
> https://github.com/llvm/llvm-project/blob/main/lldb/test/Shell/lit.cfg.py#L65
>
> Instead of every subproject adding their own conditions for similar features, would it make sense to move these definitions to somewhere where all subprojects could use those same lit features? Would that be in `/llvm/utils/lit/lit/llvm/config.py`?

Maybe, but keep in mind that those kinds of tests should be the exception, not the rule.

As clang (and flang too, I would presume) generally can be cross compiling, one shouldn't imply that you need to be running on windows, to be able to test how the clang driver behaves when targeting windows. You can test that on any system, by passing `-target x86_64-windows-msvc` to the e.g. clang command in a lit test, so you can get test coverage for that aspect of the functionality regardless of what system you're running. Most tests in `clang/test/Driver` work that way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126291/new/

https://reviews.llvm.org/D126291