[PATCH] D126291: [flang][Driver] Update link job on windows

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 10 08:37:00 PDT 2022


mstorsjo added a comment.

In D126291#3573137 <https://reviews.llvm.org/D126291#3573137>, @mmuetzel wrote:

> Not sure if this is the right place to add this. But maybe something like this could be used to add 'windows-msvc' and 'windows-gnu' features that could be used to run tests conditionally on Windows with MSVC or MinGW toolchains:
>
>   diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
>   index b65316128146..8b911997a876 100644
>   --- a/llvm/utils/lit/lit/llvm/config.py
>   +++ b/llvm/utils/lit/lit/llvm/config.py
>   @@ -134,6 +134,10 @@ class LLVMConfig(object):
>                    features.add('target-aarch64')
>                elif re.match(r'^arm.*', target_triple):
>                    features.add('target-arm')
>   +            if re.match(r'.*-windows-msvc', target_triple):
>   +                features.add('windows-msvc')
>   +            elif re.match(r'.*-windows-gnu', target_triple):
>   +                features.add('windows-gnu')
>    
>            use_gmalloc = lit_config.params.get('use_gmalloc', None)
>            if lit.util.pythonize_bool(use_gmalloc):`

FWIW, something very similar was added just a couple days ago in an lldb specific lit.cfg.py: https://reviews.llvm.org/D127048#change-KJ7QgKPHtN1S


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126291/new/

https://reviews.llvm.org/D126291



More information about the cfe-commits mailing list