[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command
Jun Zhang via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 10 01:54:16 PDT 2022
junaire added inline comments.
================
Comment at: clang/lib/Interpreter/IncrementalParser.cpp:180
DiagnosticsEngine &Diags = getCI()->getDiagnostics();
if (Diags.hasErrorOccurred()) {
TranslationUnitDecl *MostRecentTU = C.getTranslationUnitDecl();
----------------
v.g.vassilev wrote:
> We should call Restore here.
Though there are many logic duplicates with `Restore`, I'm not sure if we can refactor it. We have done more here than `Restore`, and `Restore` need to pass a PTU, but we only have `TranslationDecl` here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126682/new/
https://reviews.llvm.org/D126682
More information about the cfe-commits
mailing list